[EXCEL-MULTI-LOOKUP-1] feat: add maxRows arg for MultiRow inputs#1531
Draft
kevinkim-ogp wants to merge 2 commits intodevelop-v2from
Draft
[EXCEL-MULTI-LOOKUP-1] feat: add maxRows arg for MultiRow inputs#1531kevinkim-ogp wants to merge 2 commits intodevelop-v2from
kevinkim-ogp wants to merge 2 commits intodevelop-v2from
Conversation
Contributor
Author
How to use the Graphite Merge QueueAdd the label lfg to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
kevinkim-ogp
changed the title
kevinkim-ogp
force-pushed
the
feat/multi-row-max-rows
branch
from
9a6bf57 to
d6908e2
Compare
12 tasks
kevinkim-ogp
force-pushed
the
feat/multi-row-max-rows
branch
from
d6908e2 to
fab088c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Added
maxRowsproperty to multirow components to limit the number of rows that can be added.What changed?
maxRowsfield to theActionSubstepArgumentGraphQL schemaMultiRowPropsand related interfaces to include optionalmaxRowspropertymaxRowslimitmaxRowsvaluemaxRowsin multirow field interfacesHow to test?
multirowormultirow-multicolinput with themaxRowsargumentmaxRowsis 1, you should not be able to add rows on initmultirowandmultirow-multicolinputs still work as intended